Move examples of rendering elements from CodePen into ./examples #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for reactjs ready! Built with commit 72e7547 |
bvaughn
reviewed
Jan 11, 2018
content/docs/rendering-elements.md
Outdated
| @@ -72,7 +72,7 @@ function tick() { | |||
| setInterval(tick, 1000); | |||
| ``` | |||
There was a problem hiding this comment.
We can also replace this whole inline example above!
content/docs/rendering-elements.md
Outdated
| @@ -43,7 +43,7 @@ ReactDOM.render( | |||
| ); | |||
| ``` | |||
There was a problem hiding this comment.
We can also replace the inline example above by embedding the new snippet too, like we do for the "file" input type. 😁
This is possible using the gatsby-remark-embed-snippet plugin
Check out PR #323 for another example of this.
|
Thanks for the suggestions! I will implement them this weekend. |
|
All done @bvaughn. Can you please take another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move two examples in the Rendering Elements Quickstart article from CodePen to the
examplesdirectory. This follows up on the work in #246.